[Bug 28737] shell32: invalid free in BrsFolderDlgProc in func_brsfolder in "make brsfolder.ok"?

wine-bugs at winehq.org wine-bugs at winehq.org
Tue Oct 18 15:25:49 CDT 2011


http://bugs.winehq.org/show_bug.cgi?id=28737

--- Comment #4 from Austin English <austinenglish at gmail.com> 2011-10-18 15:25:49 CDT ---
(In reply to comment #3)
> That patch has whitespace changes (so many it's hard to see the real change).
> Can you regenerate it without the whitespace changes?

austin at aw25 ~/wine-git/dlls/shell32 $ git diff -w . | more
diff --git a/dlls/shell32/shfldr_unixfs.c b/dlls/shell32/shfldr_unixfs.c
index 9649df8..ce30d52 100644
--- a/dlls/shell32/shfldr_unixfs.c
+++ b/dlls/shell32/shfldr_unixfs.c
@@ -2440,6 +2440,7 @@ static HRESULT WINAPI
UnixSubFolderIterator_IEnumIDList_Next(IEnumIDList* iface,
                 !UNIXFS_is_pidl_of_type(rgelt[i], This->m_fFilter)) 
             {
                 SHFree(rgelt[i]);
+                regelt[i] = NULL;
                 continue;
             }
             memset(((PBYTE)rgelt[i])+rgelt[i]->mkid.cb, 0, sizeof(USHORT));

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list