[Bug 28737] shell32: invalid free in BrsFolderDlgProc in func_brsfolder in "make brsfolder.ok"?

wine-bugs at winehq.org wine-bugs at winehq.org
Wed Oct 19 14:23:45 CDT 2011


http://bugs.winehq.org/show_bug.cgi?id=28737

--- Comment #6 from Michael Mc Donnell <michael at mcdonnell.dk> 2011-10-19 14:23:45 CDT ---
(In reply to comment #2)
> Created attachment 36987 [details]
> Patch that sets pointer to NULL after free to avoid double free
> 
> This patch fixes the valgrind warning by setting the pointer to NULL in case of
> failure. I'm not going to send this to wine-patches because it really needs a
> test as Piotr Caban says.

On second thought. I don't think this patch will hurt anything because the
pointer it sets to NULL have already been set to a garbage value. A tests to
show if the value is changed in the first place would however be nice. 

Any thoughts?

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list