[Bug 30418] regedit crash on export some binary values

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=30418

--- Comment #3 from Ilya Basin <basinilya at gmail.com> 2012-04-12 08:14:54 CDT ---
Look at this line of code:
*line_len += *line_len / (REG_FILE_HEX_LINE_LEN - concat_prefix) * concat_len;

before it, *line_len == 5561 , which is already wrong: the length of one-line
"LineStates"=hex:00,00,00,...
is 5560, not 5561.

Broken into multiple lines, this string takes 5932 chars:
"LineStates"=hex:00,00,00,00,4d,00,61,00,73,00,74,00,65,00,72,00,00,00,00,00,\
  00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,...

5932-5561=371, but the existing code only adds 370.


Instead, *line_len before the formula should be 5560 and the formula should
evaluate to 372, which is 
(nlines-1) * 5 + 2, where
nlines - number of lines
5 - the length of "\\\r\n  "
2 - the length "\r\n"

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.