[Bug 25261] AutoCAD 2009 LT: Running AcDelTree.exe crashes

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=25261

Carlo Bramini <carlo.bramix at libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlo.bramix at libero.it

--- Comment #3 from Carlo Bramini <carlo.bramix at libero.it> 2012-04-14 14:06:41 CDT ---
I looked the terminal output in the attachment of this bug and then I did some
debugging on Windows.
I tested StrCpyW and also StrCatW (my intuition suggested me to do so) and I
discovered that:

StrCpyW(myDestination, mySource) does not crash, it copies the content of
mySource into myDestination, pointer to myDestination is returned.

StrCpyW(myDestination, NULL) does not crash, it leaves myDestination unchanged,
pointer to myDestination is returned.

StrCpyW(NULL, NULL) does not crash, it returns NULL.

StrCatW has the same behavior of StrCpyW.
Actually, it seems to me that many string functions implemented into shlwapi
are already protected against wrong parameters, evidently StrCpyW and StrCatW
have need the same fixes that have been made elsewhere, since strcpyW and
strcatW don't do it.

I made a patch with this fix here:

http://source.winehq.org/patches/data/85432

Sincerely,

Carlo Bramini.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.