[Bug 9425] Select behavior different on Wine

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=9425

--- Comment #32 from Bruno Jesus <00cpxxx at gmail.com> 2012-02-09 20:32:52 CST ---
(In reply to comment #31)
> BUT the important point here in 1.and 2. is related to your fix "avoid
> false-positive write FDs". These removed POLLHUPs have to go either to readfds
> or exceptfds because if not then the programmer will think it's just timeout,
> probably trying select again, probably closing that connection after a timeout
> period. He does this although he could have known much earlier that connection
> is dead. Application will still work perfectly but it could have overall
> performance impact.

In this stage of the connection I think they should go to the exceptfds only. I
guess the readfds will not be set because it's not used in the connecting
process.

> So you fix bugs not if you see them clearly but only after a user run into
> them?

Sometimes that's the strategy, it's the easiest way because there is an ocean
of things to do so it's easier to fix what users are interested in. In the
other hand you can always add new "todos" to the code and implement them, you
need to port your tests into wine and them the fixes are easier to get
accepted.

> POLLPRI has always to go into exceptfds, thats the easiest one to fix.

Yeah, most of the times. Just don't forget the OOBINLINE usage.

> If nobody else picks this up I would try to fix some of the points. At the
> moment less on time maybe when I'll feel the need to do sports at some weekend.

Excelent, I'll be happy to help but I'll be away from wine and the computer at
all in the next 10 days. Just remember: tests first with todos and then
implementation and fixes.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.