[Bug 29585] wineoss.drv audio renderer not on par with others

wine-bugs at winehq.org wine-bugs at winehq.org
Wed Jan 25 11:15:25 CST 2012


http://bugs.winehq.org/show_bug.cgi?id=29585

--- Comment #12 from Andrew Eikum <aeikum at codeweavers.com> 2012-01-25 11:15:25 CST ---
(In reply to comment #11)
> >Now it works basically the same as the ALSA driver [...]
> Good for 1.4.  Congratulations!
> BTW, the other day I ran a diff between winealsa and wineoss and made a note
> that a patch is needed one day to eliminate gratuitous differences between the
> three drivers.  Beside that, it also revealed one error in wineoss (bad
> pointer/offset update), but I forgot where.  Maybe you'll spot that and fix it
> too.

Yep, found it:

         memcpy(This->tmp_buffer, This->local_buffer + offs_bytes,
chunk_bytes);
-        memcpy(This->tmp_buffer, This->local_buffer,
+        memcpy(This->tmp_buffer + chunk_bytes, This->local_buffer,
                 frames_bytes - chunk_bytes);

Patches are sent.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list