[Bug 30798] gdiplus: GdipNewInstalledFontCollection fails in case system have got at least one OTF font installed

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=30798

Dmitry Timoshkov <dmitry at baikal.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Dmitry Timoshkov <dmitry at baikal.ru> 2012-06-02 04:39:52 CDT ---
(In reply to comment #5)
> Dmitry, did you mean that the line 1374 is one to be blamed instead of 647?
> 
> $ git blame -L 1374,1374 font.c
> 531219f8 (Vincent Povirk 2010-04-15 11:49:20 -0500 1374)     if (type ==
> RASTER_FONTTYPE)

I was referring to

> Recently I had been investigating Wine testcase failures on my linux box and
> one of them being gdiplus testcase failing two tests at lines font.c:396 and
> font.c:397.

The change introduced by 83e88af325c993fad3052cb9e29fd137c332bb87 looks like
this:

@@ -550,35 +625,84 @@ GpStatus WINGDIPAPI GdipGetFontHeightGivenDPI(GDIPCONST
GpFont *font, REAL dpi,
 static INT CALLBACK is_font_installed_proc(const LOGFONTW *elf,
                             const TEXTMETRICW *ntm, DWORD type, LPARAM lParam)
 {
-    if (!ntm || type == RASTER_FONTTYPE)
-    {
+    if (type != TRUETYPE_FONTTYPE)
         return 1;
-    }

'if (!ntm)' check is clearly wrong, so you may change back
'if (type != TRUETYPE_FONTTYPE)' to 'if (type == RASTER_FONTTYPE)',
and send a patch.

P.S.
Adding me to cc: list usually does nothing, this bugzilla is mostly ignored/
filtered out these days.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.