[Bug 30115] New: Perfect World: Skills and items icons messed up (regression)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=30115

             Bug #: 30115
           Summary: Perfect World: Skills and items icons messed up
                    (regression)
           Product: Wine
           Version: 1.3.26
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: mooroon2 at mail.ru
                CC: hverbeet at gmail.com
    Classification: Unclassified
   Regression SHA1: a84275075d4a20a9a7f42eda01585d34f31b56d4


It is a well-known regression that had been reported ages ago to APPDB, but it
seems that no one had took care to proceed with the regression testing so far.
The problem manifests itself as the all in-game icons representing items inside
the inventory or skills in hotbars/learning trees/e.t.c. - are "messed up".
"Messed up" in this case means that, for example, for an item "sword" you would
got displayed anything else other than "sword" icon. 

This problem is actual with latest Wine (1.4), and seems to affect all the
localized versions of PW out there: I've seen complaints about this bug
affecting PW International on APPDB PWI page, I've seen complaints about messed
up icons on Chinese forums, e.t.c. The regression testing I had done had been
held using localized Russian version of PW client (by Mail.Ru, downloaded from
pw.mail.ru). Unfortunately I can't repeat the test using international version
as IPs belonging to AS located in Russia are region-restricted from
registration/playing on PWI servers.

This regression is a bit tricky and it was a bit hard to cut the things down to
a single commit id. Problem with straightforward bisecting is as follows: the
game works OK up to but not including commit a8427507. Starting with commit
a8427507 and up to but not including commit 156d24c6 the game refuses to start
hanging early during startup process and displaying so-called "red traffic
light" bugreporting dialog box. From commit 156d24c6 onward the game starts up
but with  icons messed up.

Checking out commit 156d24c6, and then reverting commit a8427507 using "git
show a8427507 | git apply -R --" fixes an issue making icons to be displayed as
they expected to be. Checking out any revision in-between a8427507..156d24c6
and trying to compile and run the game with is "as is" results in game hang on
startup. Checking out any revision in-between a8427507..156d24c6, reverting
commit a8427507 and compiling wine results in the normal game startup and
correct skills/items icons.

Just for completeness, here is "git bisect" results:
=================================================================

First commit where the game stops working:
[lexa2 at lx2linux wine-git]$ git bisect bad
a84275075d4a20a9a7f42eda01585d34f31b56d4 is the first bad commit
commit a84275075d4a20a9a7f42eda01585d34f31b56d4
Author: Henri Verbeet <hverbeet at codeweavers.com>
Date:   Thu Aug 4 19:53:27 2011 +0200

    wined3d: Implement wined3d_surface_bltfast() on top of
wined3d_surface_blt().

:040000 040000 1ee4ae032b4da38d6ba772665b4c57f55756111a
a069811143e3a52a9c6172d8bdd089f2914aac77 M      dlls

=================================================================

First commit where the game starts working:
[lexa2 at lx2linux wine-git]$ git bisect good
156d24c63466479e72811ce0bddef1d5ec754998 is the first bad commit
commit 156d24c63466479e72811ce0bddef1d5ec754998
Author: Henri Verbeet <hverbeet at codeweavers.com>
Date:   Sun Aug 21 21:34:51 2011 +0200

    wined3d: Add compressed surface support to surface_cpu_blt().

:040000 040000 d8022e36543d1aaa2b3c7cb51e2918b1ded5853c
00af3b1b397df5c13b3c84b1dc6f53c6493229be M      dlls

=================================================================

Finally, system specs: 32bit linux, kernel 2.6.38.8-32.i686.PAE, nVIDIA drivers
295.17, GeForce GTX 550 Ti 1024MB, 6Gb of DDR2 RAM, AMD Phenom II X4 955 CPU,
gcc 4.4.5 20101112 (Red Hat 4.4.5-2).

P.S. Henri, in case you won't be able to reproduce this problem on your rig - I
would capture and post here any logs you would request from me. Thanks in
advance for spending your time fixing this regression.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.