[Bug 32003] Properly account for WineTestBot errors

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=32003

François Gouget <fgouget at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|wine-bugs at winehq.org        |fgouget at codeweavers.com

--- Comment #1 from François Gouget <fgouget at codeweavers.com> 2012-10-24 17:24:32 CDT ---
The logic for UpdateStatus() and Check(), where it is duplicated, is broken: if
a task failed its step is marked as failed but the job won't be marked as
failed unless the step was a build step. Presumably this was done this way to
avoid having test failures cause a job to be marked as failed. However a task
status only reflects whether the task ran as expected. So if there are test
failures the TestFailures field will be non-zero and the Status 'completed'.

I will send a patch to fix this and deduplicate the code.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.