[Bug 31768] New: Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=31768

             Bug #: 31768
           Summary: Starcraft: Brood War loses mouse focus when using
                    ICCup's W-Mode plugin
           Product: Wine
           Version: 1.5.13
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: palmem at comcast.net
    Classification: Unclassified
   Regression SHA1: ff60249cab238bed124b98a7624ccfe415f8648e


Created attachment 41801
  --> http://bugs.winehq.org/attachment.cgi?id=41801
Smallest portion of ff60249cab238bed124b98a7624ccfe415f8648e that causes my
regression

When running Starcraft: Brood War via ICCup's launcher with the W-Mode plugin
enabled the mouse grab functionality (Alt+F1) no longer works as of wine-1.5.11
(the last working version was wine-1.5.10).  I tested with wine-1.5.12 and
wine-1.5.13, neither of which solves the problem.

I used git-bisect to track down this regression to commit 
f60249cab238bed124b98a7624ccfe415f8648e.  I don't really understand any of this
patch, but I found that reverting that commit does fix the regression I'm
experiencing.

I then messed around with the offending commit a bit and discovered that
reverting a single line is sufficient to fix the regression for me.  I've
attached that single line patch, which applies against the current git head. 
Like I said, I know nothing about this code so my fix is probably wrong. 
Hopefully someone who understands the problem will be able to come up with a
proper fix :).

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.