[Bug 31791] New: Cedar Logic crashes when you press F1

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=31791

             Bug #: 31791
           Summary: Cedar Logic crashes when you press F1
           Product: Wine
           Version: 1.5.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: hhctrl.ocx
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: dank at kegel.com
    Classification: Unclassified


Saw this while trying to reproduce bug 31778.
On wine-1.5.11-188-g77632f0, installing
http://superb-dca2.dl.sourceforge.net/project/cedarlogic/CEDAR%20Logic%201.5%20Release/cedarlssetup.exe
went fine, and the app started up fine, but pressing F1 (or Help / Contents)
crashed with
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code
(0x7d6ad919).
Backtrace:
=>0 CreateViewer+0x229(pHHInfo=0x207c18) [dlls/hhctrl.ocx/help.c:1660]
  1 CreateHelpViewer+0x9d(filename="C:\Program Files\CEDAR
Logic\KLS_Logic.chm", caller=0x10068) [dlls/hhctrl.ocx/help.c:1808] 
  2 HtmlHelpW+0xc4(caller=0x10068, filename="C:\Program Files\CEDAR
Logic\.\KLS_Logic.chm", command=0, data=0) [dlls/hhctrl.ocx/hhctrl.c:184]
  3 HtmlHelpA+0x10e(caller=0x10068, filename="C:\Program Files\CEDAR
Logic\.\KLS_Logic.chm", command=0, data=0) [dlls/hhctrl.ocx/hhctrl.c:355]
  4 0x0056ca9b in cedarls (+0x16ca9a) (0x00a4f638)
...
0x7d6ad919 CreateViewer+0x229 [/home/dank/wine-git/dlls/hhctrl.ocx/help.c:1660]
in hhctrl: cmpw    $0,0x0(%esi)
1660        if (!*caption) caption = info->pCHMInfo->defTitle;

Looks like a314027b4211ddd045e12bd768962c3c47f56d68 missed a trick.
The superficial fix

-    if (!*caption) caption = info->pCHMInfo->defTitle;
+    if (!caption || !*caption) caption = info->pCHMInfo->defTitle;

lets help start.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.