[Bug 33378] measuring/painting strings needs better tests

wine-bugs at winehq.org wine-bugs at winehq.org
Sat Aug 3 00:57:03 CDT 2013


http://bugs.winehq.org/show_bug.cgi?id=33378

--- Comment #13 from Dmitry Timoshkov <dmitry at baikal.ru> 2013-08-03 00:57:03 CDT ---
(In reply to comment #11)
> > > ...of course, given the status of plain C API of gdiplus by Microsoft, there's
> > > a chance it's only reproducible only with C++ API and PointF& version of
> > > DrawString calls.
> > 
> > There is no such a thing as C++ gdiplus API.
> > 
> Sure there is.
> I.e. 
> Graphics.DrawString(const WCHAR*, INT, const Font*, const PointF, const Brush*)

That's not an API, this is not a gdiplus.dll public export.

> But it seems at least *parts* of it aren't implemented in wine.
> At very least namespacing seems broken.

What you are talking about is C++ wrappers around public gdiplus APIs.

> > You need to write the tests and run them under Windows before you'll start
> > to play with them under Wine, otherwise it's pretty easy to confuse yourself
> > with controversial results.
> > 
> 
> ...and I would build them with...
> That's assuming I'd be willing to install the whole toolchain under Windows
> (and that's assuming it would be an option for me in the first place).

That's how it usually works, you can't assume how win32 API actually works
without testing it under Windows. Testbot only helps to extend API coverage
by providing more Windows platform versions, in general you can't create
a test by observing only testbot VMs behaviour.

> With 6ab04040e52465e77558a067309e8a54bdc0f32c regression being clear, somebody
> does need to test it with Windows, but, as I said, I'm unsure if C++ won't be
> needed to show it.

In order to test gdiplus behaviour it's not required to use C++ (and existing
gdiplus tests prove this), moreover C++ usage is harmful since it hides actual
details about public API usage.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list