[Bug 17195] NamedPipe datagrams need to be _really_ datagrams

wine-bugs at winehq.org wine-bugs at winehq.org
Thu Jan 3 04:09:32 CST 2013


http://bugs.winehq.org/show_bug.cgi?id=17195

--- Comment #122 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> 2013-01-03 04:09:32 CST ---
i'm going to suggest that this and other renames be made as separate patches. 
it's very unclear that there's anything significant to review here, because the
only thing that's happening is pipe_server and pipe_instance are being renamed,
and server to end.

oh wait!  event is also being renamed to event_empty which is highly
significant, and buried within the renaming.


-static void notify_empty( struct pipe_server *server )
+static void notify_empty( struct pipe_instance *end )
 {
-    if (!server->flush_poll)
+    if (!end->flush_poll)
         return;
-    assert( server->state == ps_connected );
-    assert( server->event );
-    remove_timeout_user( server->flush_poll );
-    server->flush_poll = NULL;
-    set_event( server->event );
-    release_object( server->event );
-    server->event = NULL;
+    assert( end->state == ps_connected );
+    assert( end->event_empty );
+    remove_timeout_user( end->flush_poll );
+    end->flush_poll = NULL;
+    set_event( end->event_empty );
+    release_object( end->event_empty );
+    end->event_empty = NULL;
 }

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list