[Bug 34472] window titlebar names

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=34472

--- Comment #3 from Ken Thomases <ken at codeweavers.com> 2013-10-14 19:12:05 CDT ---
Curious.  I didn't expect it to be solvable so "locally".  I assumed that a
window without a title bar simply couldn't have a title, so we would have to
save it in an instance variable until the style changed back to titled.  Seems
to work fine, though.

A few suggestions:

* The patch doesn't apply to current git.  The indenting is different. 
(Perhaps you've re-indented your working copy because you hate the extra
indenting that's in Wine?)

* I think it's best to copy the original title.  Your approach seems to be
working but, given that Cocoa is losing the window's title, it may release the
string it gave us.  Of course, if we copy it, we need to release it.  I suggest
just [[... copy] autorelease] around what you've got.

* Submit it to wine-patches, since patches won't be picked up from the bug
tracker.


If you're not interested in pursuing it, let me know and I can tweak and submit
it.  Thanks.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.