[Bug 33164] row-resize / col-resize cursor is wrong (Listview)
wine-bugs at winehq.org
wine-bugs at winehq.org
Sun Oct 27 14:03:24 CDT 2013
http://bugs.winehq.org/show_bug.cgi?id=33164
--- Comment #7 from Qian Hong <fracting at gmail.com> 2013-10-27 14:03:24 CDT ---
Hello,
Thanks, I've reproduce the bug, confirming.
@@ -868,7 +868,7 @@ static const struct cursor_font_fallback fallbacks[] =
{ "circle", XC_circle },
{ "clock", XC_clock },
{ "coffee_mug", XC_coffee_mug },
- { "col-resize", XC_sb_v_double_arrow },
+ { "row-resize", XC_sb_v_double_arrow },
{ "cross", XC_cross },
{ "cross_reverse", XC_cross_reverse },
{ "crosshair", XC_crosshair },
@@ -905,7 +905,7 @@ static const struct cursor_font_fallback fallbacks[] =
{ "right_side", XC_right_side },
{ "right_tee", XC_right_tee },
{ "rightbutton", XC_rightbutton },
- { "row-resize", XC_sb_h_double_arrow },
+ { "col-resize", XC_sb_h_double_arrow },
{ "rtl_logo", XC_rtl_logo },
{ "sailboat", XC_sailboat },
{ "sb_down_arrow", XC_sb_down_arrow },
This part is wrong, fallbacks[] should be a sorted array, find_fallback_shape()
uses a bsearch() to find the fallback by name, your change breaks the order.
Other wise the patch looks good to me, please correct the wrong part and send a
"try 2", see http://wiki.winehq.org/SubmittingPatches for more details.
Thanks for the work!
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
More information about the wine-bugs
mailing list