[Bug 33051] Ctrl+]/[ does not work in gvim

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=33051

--- Comment #7 from Qian Hong <fracting at gmail.com> 2013-10-28 04:06:28 CDT ---
(In reply to comment #6)
> What's the problem then? It works quite well for me.

Works well for something is the easy part, the hard part is to clearly
understand the original code and make sure not to break anything :)

I would suggest to add some test case in
dlls/user32/tests/input.c:1541:test_ToUnicode()
,to approve your change is correct. It would be great to also test for some
other case such as Ctrl+\, Ctrl+^, Ctrl+_ and Ctrl+`, which satisfy the
expression "(keysym > 'Z') && (keysym < 'a')", then we can get an idea if they
works the same as Ctrl+]/[. If they works the same, we could have a more
general patch. The more tests the better.

You can cross compile the test case and run on a Windows machine. If you don't
have Windows you can submit either the patch or the compiled binary to our Wine
testbot, see http://wiki.winehq.org/WineTestBot 
and 
http://wiki.winehq.org/CompilingDLLsUsingMingw

If you have trouble getting a testbot account please let me know.

Thanks for the work.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.