[Bug 26101] riched20/editor tests show a ton of valgrind warnings

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=26101

--- Comment #7 from Jactry Zeng <jactry92 at gmail.com> ---
Hi,
(In reply to Austin English from comment #6)
> (In reply to Jactry Zeng from comment #5)
> > Created attachment 49366 [details]
> > possible fix
> > 
> > Hi Austin, Dan,
> > (In reply to Austin English from comment #0)
> > > Created attachment 33289 [details]
> > > valgrind log
> > 
> > Here is a possible fix.
> 
> The patch helps, though there are still the uninitialized values in
> test_EM_FINDWORDBREAK_A from comment #1 (that would be a separate bug, of
> course).

Thanks for your testing!

I cannot find the error in comment #1, but there was another one:
==28062== Conditional jump or move depends on uninitialised value(s)
==28062==    at 0x4E21938: bitmapinfoheader_from_user_bitmapinfo (dib.c:182)
==28062==    by 0x4E24462: GetDIBits (dib.c:1217)
==28062==    by 0x5135DB5: create_icon_pixmaps.isra.10 (window.c:546)
==28062==    by 0x5137F17: fetch_icon_data (window.c:631)
==28062==    by 0x513ABAB: X11DRV_WindowPosChanged (window.c:2325)
==28062==    by 0x4D4D057: set_window_pos (winpos.c:2147)
==28062==    by 0x4D4FB78: USER_SetWindowPos (winpos.c:2220)
==28062==    by 0x4D4D2D6: SetWindowPos (winpos.c:2294)
==28062==    by 0x4D4E95E: show_window (winpos.c:1122)
==28062==    by 0x4D4EC92: ShowWindow (winpos.c:1220)
==28062==    by 0x4C15C83: main (wineboot.c:932)
==28062==  Uninitialised value was created by a stack allocation
==28062==    at 0x5135C98: create_icon_pixmaps.isra.10 (window.c:530)
==28062== 

Which has been reported as Bug 30827.

Is the command I used right? I'm not so familiar to valgrind,:
$ valgrind --tool=memcheck --leak-check=full --trace-children=yes
--workaround-gcc296-bugs=yes --num-callers=20 ../../../tools/runtest -q -P wine
-T ../../.. -M riched20.dll -p riched20_test.exe.so editor &> ~/editor_log.txt

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.