[Bug 36191] valgrind shows some potential leaks in crypt32/tests/cert.c

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=36191

marc.bessieres at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marc.bessieres at gmail.com

--- Comment #3 from marc.bessieres at gmail.com ---
Created attachment 50140
  --> https://bugs.winehq.org/attachment.cgi?id=50140
fix for definitely lost in testAddCert

Hi Austin,

In attachment I put a patch for the definite leak you reported:
Also a definite leak:
==17318== 48 bytes in 1 blocks are definitely lost in loss record 159 of 334
==17318==    at 0x7BC4C6B7: notify_alloc (heap.c:255)
==17318==    by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716)
==17318==    by 0x4EE398B: CryptMemAlloc (main.c:124)
==17318==    by 0x4EBE5A6: Context_CreateLinkContext (context.c:60)
==17318==    by 0x4EAAB00: Cert_clone (cert.c:127)
==17318==    by 0x4EBD199: CRYPT_CollectionCreateContextFromChild
(collectionstore.c:85)
==17318==    by 0x4EBD485: CRYPT_CollectionAdvanceEnum (collectionstore.c:174)
==17318==    by 0x4EBD6EE: Collection_enumCert (collectionstore.c:247)
==17318==    by 0x4F05CB9: CertEnumCertificatesInStore (store.c:946)
==17318==    by 0x4EAE3F7: cert_compare_certs_in_store (cert.c:1528)
==17318==    by 0x4EAEF02: CertFindCertificateInStore (cert.c:1794)
==17318==    by 0x4EAAD3C: add_cert_to_store (cert.c:192)
==17318==    by 0x4EAB27F: CertAddCertificateContextToStore (cert.c:287)
==17318==    by 0x4CC9B54: testAddCert (cert.c:306)
==17318==    by 0x4CD8F2F: func_cert (cert.c:3976)
==17318==    by 0x4D33F67: run_test (test.h:584)
==17318==    by 0x4D34356: main (test.h:654)

The problem was that CertFindCertificateInStore was not called for a variable
allocated with CertFindCertificateInStore.

If you have some time could you check if it works for you?
And also could you check if the patch seems correct?

Cheers,
Marc

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.