[Bug 33947] Battle.net desktop app crashes after 15 seconds

wine-bugs at winehq.org wine-bugs at winehq.org
Sat Jan 4 23:24:48 CST 2014


http://bugs.winehq.org/show_bug.cgi?id=33947

--- Comment #30 from Ryan Davis <iconoclasmandheresy at gmail.com> ---
Well... the commit message was my own internal one, so perhaps wasn't all
clear. All credit goes to Ben. All I did was massage it a little so it applied
after some variable names got changed. I was actually surprised that it
compiled afterward... so it's Ben's patch and all credit should go where due.

If you look back in the issue log here, you'll see that the patch was submitted
earlier and found unsuitable. There was a bunch of good criticism, and I
changed nothing to make it any different. I'm not a good enough coder to bring
the patch up to spec, so re-submitting it to be incorporated upstream seemed
useless. Again, someone with better chops than I have should look over the
criticism and incorporate it into something that a) meets project standards &
best practices b) doesn't throw warnings during compilation.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list