[Bug 2082] DirectDraw games only showing black screen

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=2082

--- Comment #134 from Henri Verbeet <hverbeet at gmail.com> ---
(In reply to comment #133)
> Created attachment 47148 [details]
> Test z-order in ddraw tests
> 
> To my surprise, SetForegroundWindow() has nothing to do with z-order, at
> all.  It just affects foreground/active statuses which are related to focus.
> 
> This patch modifies the ddraw tests to check z-order.  In all of the places
> that used to call SetForegroundWindow(), I now also call SetWindowPos(…,
> HWND_TOP, …).  In all of the places that checked the window returned from
> GetForegroundWindow(), I now also check the window order.  I also check the
> z-order immediately after attempting to set it to verify that it's working.
> 
We don't want new tests to go anywhere that isn't ddraw[1247].c. (And the
existing ones should get cleaned up and moved over to there eventually as
well.)

> The tests marked "todo_wine" in testcooperativelevels_normal() are due to
> ddraw/wined3d setting the window topmost for fullscreen and, in some cases,
> not restoring it.
> 
Right, setting WS_EX_TOPMOST is correct for d3d8 and d3d9, it isn't for ddraw.
(See also the various versions of test_window_style().)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.