[Bug 36636] valgrind shows an uninitialized write in shell32/tests/appbar.c

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=36636

--- Comment #7 from Nikolay Sivov <bunglehead at gmail.com> ---
(In reply to Bruno Jesus from comment #5)
> Created attachment 48795 [details]
> patch 3
> 
> I think all abd variables are properly initialized now.

---
+    memset(&command.abd, 0, sizeof(command.abd));
     command.abd.hWnd = HandleToLong( data->hWnd );
     command.abd.uCallbackMessage = data->uCallbackMessage;
     command.abd.uEdge = data->uEdge;
---

That's too much, you only need to set command.abd.cbSize. Same applies for two
other cases - it's better to add what's missing, instead of memset and
immediately overwrite it.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.