[Bug 36435] New: Adobe Flash Builder 4.6 uses potentially erroneous shell32.dll PathYetAnotherMakeUniqueName stub

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=36435

            Bug ID: 36435
           Summary: Adobe Flash Builder 4.6 uses potentially erroneous
                    shell32.dll PathYetAnotherMakeUniqueName stub
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: wine-bugs at winehq.org
          Reporter: focht at gmx.net

Hello folks,

nothing serious .. the stub lies: it returns 'TRUE' (success, buffer filled)
but doesn't touch the 'out' buffer at all.

Applications might peek into uninitialized/garbage data (stack, heap), finding
NULL terminator by chance.

--- snip ---
$ WINEDEBUG=+tid,+seh,+relay wine ./FlashBuilder_4_6_LS10.exe >>log.txt 2>&1
...
fixme:shell:PathYetAnotherMakeUniqueName (0x26afec8, L"C:\\adobeTemp\\backup",
L"tmp" ,L"adobetmp000126541"):stub.
--- snip ---

Source:
http://source.winehq.org/git/wine.git/blob/4903dda319f092af37f5b0e58716e3a0cb7aa025:/dlls/shell32/shellpath.c#l538

--- snip ---
538 /*************************************************************************
539  * PathYetAnotherMakeUniqueName [SHELL32.75]
540  *
541  * NOTES
542  * exported by ordinal
543  */
544 BOOL WINAPI PathYetAnotherMakeUniqueName(
545          LPWSTR lpszBuffer,
546          LPCWSTR lpszPathName,
547          LPCWSTR lpszShortName,
548          LPCWSTR lpszLongName)
549 {
550     FIXME("(%p, %s, %s ,%s):stub.\n",
551               lpszBuffer, debugstr_w(lpszPathName),
debugstr_w(lpszShortName), debugstr_w(lpszLongName));
552     return TRUE;
553 }
--- snip ---

MSDN:
http://msdn.microsoft.com/en-us/library/windows/desktop/bb776479%28v=vs.85%29.aspx

Either change the stub to return FALSE and set lasterror "unimplemented" or
flesh out the stub (not too hard).

$ sha1sum FlashBuilder_4_6_LS10.exe 
7991023d94bcf62f06eb1500914b5274b32c30ea  FlashBuilder_4_6_LS10.exe

$ du -sh FlashBuilder_4_6_LS10.exe 
819M    FlashBuilder_4_6_LS10.exe

$ wine --version
wine-1.7.18-76-gcfb81f2

Regards

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.