[Bug 37482] New: Suspicious condition (assignment + comparison); Clarify expression with parentheses. (Cppcheck)

wine-bugs at winehq.org wine-bugs at winehq.org
Thu Oct 30 20:48:49 CDT 2014


https://bugs.winehq.org/show_bug.cgi?id=37482

            Bug ID: 37482
           Summary: Suspicious condition (assignment + comparison);
                    Clarify expression with parentheses. (Cppcheck)
           Product: Wine
           Version: 1.7.29
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: wine-bugs at winehq.org
          Reporter: 00cpxxx at gmail.com
                CC: mstefani at redhat.com
      Distribution: ---

[dlls\comctl32\listview.c:5056]: (style) Suspicious condition (assignment +
comparison); Clarify expression with parentheses.

 5052         /* draw the horizontal lines for the rows */
 5053         itemheight =  LISTVIEW_CalculateItemHeight(infoPtr);
 5054         rcItem.left   = infoPtr->rcList.left;
 5055         rcItem.right  = infoPtr->rcList.right;
 5056         for(y = Origin.y > 1 ? Origin.y - 1 : itemheight - 1 + Origin.y %
itemheight; y<=infoPtr->rcList.bot      tom; y+=itemheight)
 5057         {
 5058             rcItem.bottom = rcItem.top = y;
 5059             TRACE("horz rcItem=%s\n", wine_dbgstr_rect(&rcItem));
 5060             MoveToEx (hdc, rcItem.left, rcItem.top, NULL);
 5061             LineTo (hdc, rcItem.right, rcItem.top);
 5062         }

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list