[Bug 38337] clang compiling warnings

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=38337

--- Comment #3 from Sergey Isakov <isakov-sl at bk.ru> ---
(In reply to Nikolay Sivov from comment #1)
> Created attachment 51183 [details]
> msmxl warnings
> 
> For msxml3 part please try this one.

This patch is wrong you just forget to exclude old line where the warning is
line:1620.
Meanwhile, I expected assignment on each case statement without type
conversion.

I see you committed related patches so I will wait for an update.

There are also warnings with similar mistakes, for example
---
imgfactory.c:715:88: warning: implicit conversion from enumeration type
      'WICBitmapAlphaChannelOption' (aka 'enum WICBitmapAlphaChannelOption') to
different
      enumeration type 'WICBitmapCreateCacheOption' (aka 'enum
WICBitmapCreateCacheOption')
      [-Wenum-conversion]
  ...BitmapImpl_Create(bm.bmWidth, bm.bmHeight, bm.bmWidthBytes, 0, NULL,
&format, option...
     ~~~~~~~~~~~~~~~~~                                                         
   ^~~~~~
----
Should I report them separately or commit a set of patches one for each
message?
I already affraid to commit something because all my patches rejected except
&prc.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.