[Bug 20977] Bad hlp table rendering

wine-bugs at winehq.org wine-bugs at winehq.org
Mon Dec 14 17:08:13 CST 2015


https://bugs.winehq.org/show_bug.cgi?id=20977

--- Comment #11 from Matteo Bruni <matteo.mystral at gmail.com> ---
Thank you for the patch! Notice though that patches are not picked from
Bugzilla, they have to be sent to the wine-patches mailing list.

http://wiki.winehq.org/SubmittingPatches should have a number of useful tips,
other things I noticed at a very quick look:
- your patch seems to contain a number of separate fixes, you should split them
over multiple patches
- C++-style comments are not allowed in Wine
- don't add obvious comments e.g. "// JCC read the DPI from the registry", also
don't mark your changes with comments, git keeps track of code ownership just
fine ;)
- don't make random whitespace changes
- don't leave commented-out code in the patch if there isn't some particularly
good reason (and in that case, if (0) { ... } is preferred)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list