[Bug 38485] New Marvel Heroes 2015 Launcher crashes on unimplemented function dhcpcsvc.dll.DhcpRequestParams

wine-bugs at winehq.org wine-bugs at winehq.org
Mon Jun 1 13:41:25 CDT 2015


https://bugs.winehq.org/show_bug.cgi?id=38485

--- Comment #7 from André H. <nerv at dawncrow.de> ---
(In reply to Mike Ellery from comment #6)
> Thanks for the feedback, I've attached an update.  

LPDHCPCAPI_CLASSID, DHCPCAPI_PARAMS_ARRAY, DHCPCAPI_PARAMS_ARRAY, LPBYTE,
LPDWORD should also be marked as ptr in the specfile
We also try to avoid lines longer than 100 characters, i suggest to shorten the
parameter names and add line breaks
The typedefs you added should maybe go to a new include/dhcpcsdk.h, but maybe
it get's accepted this way as you only add a stub
We use 4 space indentation, your typedefs don't...
You also should use WINAPI instead of APIENTRY

I think it's worth the try sending it to the mailinglist directly after fixing
these issues. Thx for the effort

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list