[Bug 38470] __chkstk not implemented on ARM

wine-bugs at winehq.org wine-bugs at winehq.org
Sun Jun 14 15:00:42 CDT 2015


https://bugs.winehq.org/show_bug.cgi?id=38470

--- Comment #12 from André H. <nerv at dawncrow.de> ---
(In reply to MY123 from comment #11)
>   * Should check if we can decrement SP by the value provided in r4, but we
> shouldn't need that.
>   */
> -__ASM_GLOBAL_FUNC( __chkstk, "bx lr" )
> +__ASM_GLOBAL_FUNC( __chkstk, "mov r12, #4\n mul r4,r4,r12\n bx lr" )
> 

Use IP instead of r12, it's less cryptically. Also add newlines in the source
as seen elsewhere in that file (that also should avoid some whitespaces).
Use spaces after commas.
Maybe also adjust the comment.

Then you should be ready to send it to wine-patches.

Thx!

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list