[Bug 38470] __chkstk not implemented on ARM

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=38470

MY123 <mmediouni at gmx.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from MY123 <mmediouni at gmx.fr> ---
(In reply to MY123 from comment #13)
> (In reply to André H. from comment #12)
> > (In reply to MY123 from comment #11)
> > >   * Should check if we can decrement SP by the value provided in r4, but we
> > > shouldn't need that.
> > >   */
> > > -__ASM_GLOBAL_FUNC( __chkstk, "bx lr" )
> > > +__ASM_GLOBAL_FUNC( __chkstk, "mov r12, #4\n mul r4,r4,r12\n bx lr" )
> > > 
> > 
> > Use IP instead of r12, it's less cryptically. Also add newlines in the
> > source as seen elsewhere in that file (that also should avoid some
> > whitespaces).
> > Use spaces after commas.
> > Maybe also adjust the comment.
> > 
> > Then you should be ready to send it to wine-patches.
> > 
> > Thx!
> 
> patch sent

Fixed by  2b095beac : ntdll: Multiply r4 with the word size in ARM for
__chkstk.

There is a separate issue with LLVM -mcode-model=large because that also uses
r12 for __chkstk calls, but that bug is not triggered by MSVC or the normal
LLVM  code model.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.