[Bug 8332] Applications and games using ICMP ping request report 'no connection to internet' (Wine 32-bit/64-bit preloader requires CAP_NET_RAW to create raw sockets)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=8332

--- Comment #24 from Sebastian Lackner <sebastian at fds-team.de> ---
(In reply to oiaohm from comment #23)
> After reading the system ping hack.  Yes it contains a bad practice.
> 
> Use of system command should be frowned on. Issue 1 with system is the
> possibility of coder error.   Issue 2 the command line has to be broken up
> into null terminated strings any how. Something out of exec commands should
> be used. 
> http://linux.die.net/man/3/execv
> 

I thought I mentioned it here already, but seems like I didn't. Inspired by
Brunos idea I've added a similar proof-of-concept patch to Wine Staging, which
addresses exactly these problems:

https://github.com/wine-compholio/wine-staging/blob/master/patches/iphlpapi-System_Ping/0001-iphlpapi-Fallback-to-system-ping-when-ICMP-permissio.patch

Using exec in Wine in general is not necessarily bad, but it would of course be
better to have only one "ping service" running instead of one application for
each request. Besides that the idea seems to work very well and is indeed
sufficient for a lot of applications, especially because additional
input/output parameters are translated.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.