[Bug 7425] Gothic 2 crashes without native directmusic

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=7425

--- Comment #36 from Marc Bessières <marc.bessieres at gmail.com> ---
(In reply to Bruno Jesus from comment #35)
> (In reply to Marc Bessières from comment #34)
> > Thank you Bruno for the fix.
> > I'm glad you found the issue obvious as it wasn't for me :-)
> 
> Your backtrace is certainly cryptic to me too, I was talking about my
> backtrace with wine compiled without optimization (-O0). This make it much
> more clear and with better source information.

It is obvious now that I see it, but I didn't think about changing optimization
flags to report a better crash stack trace. I'll try to remember it next time I
report a crash! Thanks for the idea!

> You are right, the three of them need to be fixed but I'm not sure a single
> patch is correct because it touches 3 different DLLs, I'll try sending
> upstream to get some feedback.

Ok, I see. 3 patches can be made for sure if needed.
By the way, I was wondering if these functions shouldn't go into a central
place instead of being copy/paste of each others, otherwise next time  we may
miss the fact that they all need to be corrected.
The commit message of 106e13ab0928036282b095250efdb04c91997054 where they were
introduced doesn't make me understand why they needed to be copy/paste of each
other, I must miss some knowledge :(
--- quote ---
    - Add the same new files (dmutils.c/dmutils.h) into dmime,dmband and
      dmstyle directory that share the debug and helper functions for dmusic
      dlls (as Rok's idea for dmloader).
--- quote ---

> By the way, before the chunk of changes in a
> patch there is always the full path to the file.
I wanted to used the emacs Tags, as I managed to repair them (still need to
send a patch for that by the way). Next time I'll use the path, thanks again
for all your feedback.

Cheers,
Marc

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.