[Bug 19160] Orly's Draw-A-Story demo crashes on startup (dmDriverExtra is not initialized)

wine-bugs at winehq.org wine-bugs at winehq.org
Fri Nov 13 13:25:31 CST 2015


https://bugs.winehq.org/show_bug.cgi?id=19160

Sebastian Lackner <sebastian at fds-team.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebastian at fds-team.de

--- Comment #9 from Sebastian Lackner <sebastian at fds-team.de> ---
(In reply to Dmitry Timoshkov from comment #8)
> (In reply to Dmitry Timoshkov from comment #7)
> > Created attachment 52081 [details]
> > patch
> > 
> > Attached patch fixes particular crash in CreateDC16 due to huge (not
> > initialized
> > dmDriverExtra) field. Application still crashes, but in a different place.
> 
> It's worth to note that it's almost impossible to test whether it's correct
> to modify dmDriverExtra in the application provided buffer, since the target
> app is 16-bit and the test has to be 16-bit as well.

Did you check if the ->Size field contains a valid value? If it also contains
some unusual value, Wine should probably ignore the whole struct.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list