[Bug 33719] comctl32:propsheet custom window proc test failure

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=33719

--- Comment #6 from François Gouget <fgouget at codeweavers.com> ---
When trying to reproduce this failure outside WineTest I found out that it was
caused by cmd.exe:batch.

The cmd tests were running regedit to clean up the registry even though they
had insufficient privileges to modify it in the first place. This caused
regedit (or Windows?) to pop up a dialog asking whether to allow regedit to
modify the registry, causing a timeout of the cmd.exe:batch test. When the
timeout occurred the cmd.exe_test.exe process got killed by winetest.exe. This
left the regedit process around though it did exit seemingly almost
immediately. Still I think it's the dialog that was causing the
comctl32:propsheet error.

I wonder if something should be done at the WineTest level to avoid this
situation. A simple solution might be to wait a couple of seconds. A better one
may be to kill the whole process tree in case of a timeout.

I sent a fix for cmd.exe:batch so comctl32:propsheet should not be bothered by
it. On Windows 7 cmd.exe:batch seemed to cause comctl32 failures in header,
listview, pager, progress and syslink} too which this fixed too.
So I don't know if it still make sense to apply this patch to
comctl32:propsheet. I guess it would make that test more robust but at the cost
of added complexity and in theory the same patch should be added to all these
other tests too.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.