[Bug 39673] New: Logical error in comparison (misprint)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=39673

            Bug ID: 39673
           Summary: Logical error in comparison (misprint)
           Product: Wine
           Version: 1.8-rc1
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: tapi32
          Assignee: wine-bugs at winehq.org
          Reporter: isakov-sl at bk.ru

Clang show me warning but this is logical mistake
----------
wine-hq/dlls/tapi32/assisted.c:63:8: warning: logical not is only applied to
      the left hand side of this comparison [-Wlogical-not-parentheses]
    if(!RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey) !=
ERROR_SUCCESS) {
       ^                                                       ~~
-----
It must be
 if(!RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey)) {

or
 if(RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey) != ERROR_SUCCESS) {

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.