[Bug 39366] FILE_ATTRIBUTE_READONLY and FILE_ATTRIBUTE_HIDDEN should perhaps use st_flags on BSD/OS X

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=39366

Guy Harris <guy at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|FILE_ATTRIBUTE_READONLY and |FILE_ATTRIBUTE_READONLY and
                   |FILE_ATTRIBUTE_HIDDEN       |FILE_ATTRIBUTE_HIDDEN
                   |should perhaps use BSD      |should perhaps use st_flags
                   |flags                       |on BSD/OS X

--- Comment #2 from Guy Harris <guy at alum.mit.edu> ---
(In reply to Sebastian Lackner from comment #1)
> Isn't this basically a duplicate of
> https://bugs.winehq.org/show_bug.cgi?id=9158?

No. For one thing, this enhancement request also mentions
FILE_ATTRIBUTE_READONLY, which bug 9158 doesn't, and, for another, that bug
seems to be talking about workarounds for the lack of FILE_ATTRIBUTE_HIDDEN
support.

> I don't see why we need a
> second bug report just to suggest a different way to implement it.

It's only "different" because the way you'd implement them would be
OS-dependent.  That bug refers to bug 15679, which has what appears to be a way
to implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM on platforms that
support fsetxattr() etc. by adding a special extended attribute.  You could get
away with that on OS X 10.4 or later, But It Would Be Wrong, at least for
FILE_ATTRIBUTE_HIDDEN, given that OS X 10.5 and later implement the native
hidden flag as UF_HIDDEN - as does Samba for OS X - so implementing it that way
*on OS X* would mean code running under Wine would see the same hidden flag
that native code does.

> Also, the
> feature is BSD/OSX specific and we still need a different implementation on
> Linux.

Yeah, I thought the "BSD" in the title would have made it sufficiently explicit
that this was a suggestion for a *platform-specific* change.  Sorry about that;
I've changed the title to make it clearer.

One possibility for a "different implementation on Linux" is the one in bug
15679, which is *not* in the master branch in the Wine git repository.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.