[Bug 39485] Logically dead code in elf_hash_symtab (Coverity #731748)

wine-bugs at winehq.org wine-bugs at winehq.org
Thu Oct 22 01:34:56 CDT 2015


https://bugs.winehq.org/show_bug.cgi?id=39485

Alex Henrie <alexhenrie24 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Alex Henrie <alexhenrie24 at gmail.com> ---
Upon closer look, I think this is actually a false positive. Coverity thinks
that if (symname) can never be null because it thinks that strp can never be
null and symname = strp + symp->st_name, but strp can be null if there is
something wrong with the image map. See:
https://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee3e43f8e7:/dlls/dbghelp/elf_module.c#l486
https://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee3e43f8e7:/dlls/dbghelp/image_private.h#l188

Sorry for trusting Coverity a bit too much here...

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list