[Bug 39494] New: Unused value in ME_RTFTblAttrHook (Coverity #1269505)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=39494

            Bug ID: 39494
           Summary: Unused value in ME_RTFTblAttrHook (Coverity #1269505)
           Product: Wine
           Version: 1.7.53
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: richedit
          Assignee: wine-bugs at winehq.org
          Reporter: alexhenrie24 at gmail.com
      Distribution: ---

CID 1269505 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value -16777216 to pFmt->rgxTabs[cellNum] here, but
that stored value is overwritten before it can be used.

value_overwrite: Overwriting previous write to pFmt->rgxTabs[cellNum] with
value from 0xffffff & info->rtfParam.

https://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee3e43f8e7:/dlls/riched20/editor.c#l944

It's not clear whether this code was supposed to be

        pFmt->rgxTabs[cellNum] &= ~0x00FFFFFF;
        pFmt->rgxTabs[cellNum] |= 0x00FFFFFF & info->rtfParam;

or just

        pFmt->rgxTabs[cellNum] = 0x00FFFFFF & info->rtfParam;

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.