[Bug 25857] Multiple games (Stronghold 2, Need for Speed: Carbon demo, Purge) fail to draw correctly because of ID3DXEffectImpl_*Pass calls

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=25857

--- Comment #51 from Wylda <wylda at volny.cz> ---
> 
> ...I am a bit confused with "IsParameterUsed" stub
> FIXME as my test patch here adds a real implementation...

Probably the reason is, that i used only patches waiting in the patches queue,
not the one attached in comment 46.

I noticed, that even if patch from comment 46 is applied on a clean wine-1.9.7
source and it is applied cleanly, it does not build with -O0:

../../tools/winegcc/winegcc -o d3dx9_36.dll.so -B../../tools/winebuild -m32
-fasynchronous-unwind-tables -shared
../../../wine_git_build/dlls/d3dx9_36/d3dx9_36.spec \
  animation.o core.o d3dx9_36_main.o effect.o font.o line.o math.o mesh.o
preshader.o render.o \
  shader.o skin.o sprite.o surface.o texture.o util.o volume.o xfile.o
version.res -ld3d9 \
  -ld3dcompiler ../../dlls/dxguid/libdxguid.a -ld3dxof -lole32 -lgdi32 -luser32
\
  ../../libs/port/libwine_port.a 
effect.o: In function `walk_parameter_tree':
/build/wine_git_build_32/dlls/d3dx9_36/../../../wine_git_build/dlls/d3dx9_36/effect.c:3687:
undefined reference to `is_type_sampler'
effect.o: In function `walk_state':
/build/wine_git_build_32/dlls/d3dx9_36/../../../wine_git_build/dlls/d3dx9_36/effect.c:3741:
undefined reference to `is_type_sampler'
collect2: error: ld returned 1 exit status


With -O2 it build fine.

> ...Still it would be great if you could attach an output with
> WINEDEBUG=+d3dx (after checking the correctness of patch usage), I would
> check if there are some evident non-implememented effect related features
> used.

I could use -O2 build and provide the log. But do you still want to check it,
when you know, that initially i didn't use the patch from comment 46 (i.e.
patches 07..11 were missing)? If useful, I'll gladly provide that.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.