[Bug 36838] TOCA Touring Car Championship: installer copies one file from CD and then shows an error

wine-bugs at winehq.org wine-bugs at winehq.org
Fri Apr 22 16:54:59 CDT 2016


https://bugs.winehq.org/show_bug.cgi?id=36838

--- Comment #21 from Bruno Jesus <00cpxxx at gmail.com> ---
(In reply to Olivier F. R. Dierick from comment #20)
> Created attachment 54337 [details]
> New patch set last error explicitly in SHFileOperation()
> 
> Set last error explicitly in any case according to latest tests.
> 
> Please check if ready for submission.

Your tests from comment 19 are not testing the W version, to have a better test
set you can clone the tests for the W version (changing the parameters
accordingly).

Since in Wine SHFileOperationA calls SHFileOperationW can't you simplify the
patch from comment 20 by adding only line 1568 and deleting line 897 from
source and not adding line 904?

If I'm not wrong the effect would be the same and the out of memory case would
not change since it is also not covered by tests.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list