[Bug 41972] "Elite: Dangerous" client crashes when starting

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=41972

--- Comment #12 from Kimmo Myllyvirta <kimmo.myllyvirta at gmail.com> ---
Created attachment 56456
  --> https://bugs.winehq.org/attachment.cgi?id=56456
quartz crash fix

It is not obvious from the debug log, but in filtergraph.c;
GetInternalConnections returns S_OK, number of pins = 1, but it doesn't
allocate and query the pppins at all.
ExploreGraph assumes everything is ok, it is not a renderer (nb != 0), loops
through the pins and calls IPin_ConnectedTo with foobar pin -> page fault.

I don't know why GetInternalConnections is implemented as it is, but how it
currently uses IPin_QueryInternalConnections is not what MSDN says about it,
and how the pins are implemented in webmsplit/vp8decoder
(https://github.com/webmproject/webmdshow).
Only the most common E_NOTIMPL path seems to be correct.

Quick fix for the crash attached.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.