[Bug 31836] Add support for GStreamer 1.0 API/ABI

wine-bugs at winehq.org wine-bugs at winehq.org
Fri Jan 22 03:14:46 CST 2016


https://bugs.winehq.org/show_bug.cgi?id=31836

--- Comment #43 from Rafał Mużyło <galtgendo at o2.pl> ---
(In reply to Alexandre Julliard from comment #42)
> Aborting configure with AC_MSG_ERROR is very unfriendly, and should only be
> used for cases that would make the resulting build useless. A broken
> gstreamer doesn't qualify. A simple notice message would be enough.

The catch is next to noone will notice such notice in the flood of the
configure messages, unless this check will only set a var and the warning is
only printed at the conclusion of the configure process.

That's not about my workflow, but about my experience with people's approach to
the content of build logs, non-failing configure parts specifically. That's the
common variant of "if it builds, it works".

That's just a personal preference, but I'd prefer to abort as soon as I know
something is broken, cause if I care, I want to fix it and if I don't, I'd know
I'd need to add '--disable-gstreamer'.


With your approach, you might just as well scrap the check altogether and build
a broken gstreamer in such case - the resulting build wouldn't be useless then,
just the gstreamer part.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list