[Bug 40830] Conflict between kVK_RightCommand and macOS 10.12 Sierra in carbon framework

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=40830

--- Comment #3 from Ken Thomases <ken at codeweavers.com> ---
Created attachment 54821
  --> https://bugs.winehq.org/attachment.cgi?id=54821
Patch to fix building against macOS 10.12 SDK

Thanks for reporting this.  I find it kind of funny that Apple updated Carbon
after all of these years and it breaks building of Wine.

On the other hand, it seems I guessed well when I picked the unused value to
assign to the invented symbol, which is good.

Your patch won't work.  You can't put an "if" statement at the top level scope
(outside of any function) like that.  Also, the conflict is a build-time
problem, while checking NSAppKitVersionNumber is a run-time thing.  It happens
too late to be useful.

Please try the patch I'm attaching and let me know if it fixes things.  I'm not
yet in a position to test it myself.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.