[Bug 40879] New: Hard coded values at wined3d_private

wine-bugs at winehq.org wine-bugs at winehq.org
Tue Jun 28 09:09:31 CDT 2016


https://bugs.winehq.org/show_bug.cgi?id=40879

            Bug ID: 40879
           Summary: Hard coded values at wined3d_private
           Product: Wine
           Version: 1.9.13
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: wine-bugs at winehq.org
          Reporter: super_man at post.com
      Distribution: ---

I noticed this while looking at wine source code.

http://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee3e43f8e7:/dlls/wined3d/wined3d_private.h#l428

 426 /* Shader backends */
 427 
 428 /* TODO: Make this dynamic, based on shader limits ? */
 429 #define MAX_ATTRIBS 16
 430 #define MAX_REG_ADDR 1
 431 #define MAX_REG_TEMP 32
 432 #define MAX_REG_TEXCRD 8
 433 #define MAX_REG_INPUT 32
 434 #define MAX_REG_OUTPUT 32
 435 #define MAX_CONST_I 16
 436 #define MAX_CONST_B 16
 437 #define WINED3D_MAX_CBS 15
 438 
 439 /* FIXME: This needs to go up to 2048 for
 440  * Shader model 3 according to msdn (and for software shaders) */
 441 #define MAX_LABELS 16

Is this hard to make dynamic?

What actually is up to 2048 and isnt?

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list