[Bug 25857] Multiple games (Stronghold 2, Need for Speed: Carbon demo, Purge) fail to draw correctly because of ID3DXEffectImpl_*Pass calls

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=25857

--- Comment #43 from Paul Gofman <gofmanp at gmail.com> ---
(In reply to super_man from comment #42)
> Your source is missing FindNextValidTechnique
> 
> https://github.com/wine-compholio/wine-staging/tree/master/patches/d3dx9_36-
> FindNextValidTechnique
> 
> But it's so related to your patch that maybe you should merge it and give
> credits to Costa.


I am not sure it is directly related, it is a distinct issue. Current stub
returning E_NOTIMPLEMENTED gives the apps depending on FindNextValidTechnique
no chance to work. That patch will allow many of such apps to run normally
(though alone it will not provide a complete implementation as it reasonably
relies on ValidateTechnique which is still a stub returning OK).

BTW is there any reason why this patch is not suggested upstream and stays in
staging since 2014? 

I suppose that if this patch is required to run or test some games (which is
clear as they should have FindNextValidTechnique FIXME in output) it should be
easy (after you gave a reference to it) to apply it independently. Or apply my
test.patch on staging. That patch is already maintained in Staging, so it
should be applied cleanly.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.