[Bug 28661] Receiving emails from AppDB when I shouldn't

wine-bugs at winehq.org wine-bugs at winehq.org
Thu Aug 3 16:28:02 CDT 2017


https://bugs.winehq.org/show_bug.cgi?id=28661

--- Comment #8 from Rosanne DiMesio <dimesio at earthlink.net> ---
I was finally able to reproduce this locally, but only when using the AppDB
backup instead of my local test database. 

All the errant emails I've received lately were about notes being added or
edited, so I took a look at those note entries in the database. All note
records have both an appId field and a versionId field. Most (3383) note
entries have a valid versionId, but the appId is set to 0. There are 214
entries that are the reverse: a valid appId with the versionId set to 0; those
are the ones triggering the emails to admins when they shouldn't. As to why
they were stored with an appId and no versionId, my testing shows that happens
when a note is originally added from the main app page rather than a version
page.

As to why this triggers emails to admins, that does go back to the check that
sends emails admins if there is no appId or versionId associated with it. Even
though a note can be added from the main app page, it can only be edited from a
version page, and only the versionId is checked when that happens. 

Removing the check for appId/versionId from get_notify_email_address_list does
stop those email notifications from being sent to admins who have disabled
global notifications, but I will also need to come up with a better way to make
sure admins still are sent the notices they should get (such as the daily cron
cleanup report) before I can do that.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list