[Bug 20728] Multiple video players crash when opening audio or video file (MPC-HC v1.6.5, PotPlayer 1.5.x)(FilterGraph_create releases/ destroys controlling IUnknown)

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=20728

--- Comment #20 from Andrew Eikum <aeikum at codeweavers.com> ---
(In reply to Rosanne DiMesio from comment #17)
> OTOH, all the .wmv files I tested still crashed on opening, with MPC-HC
> popping up its own crash dialog (when you dismiss it, Wine's crash dialog
> appears).
> 

This commit may fix some of those crashes (or maybe not):

commit ac59a68162321610841ed072981adddb8bc78c56
Author: Andrew Eikum <aeikum at codeweavers.com>
Date:   Mon Jan 9 10:46:01 2017 -0600

    quartz: Don't write past end of d3d9 buffer.

> One thing to note for testing: if you try to open another video after having
> played one without actually closing the first video from the File menu,
> MPC-HC will crash opening the second video. 
> 

Yeah, our handling of the rendering window in <quartz/vmr9.c> is problematic.
The window and message loop thread continue to run after the VMR object is
destroyed, which results in the crash. I don't see an easy way to fix this,
because the window and its parent are owned by different threads. Everything I
try ends up in a deadlock as we try to send cross-thread messages. This code
needs a re-think...

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.