[Bug 22974] "Shell folders" settings are reset after each wine update

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=22974

--- Comment #17 from Gregor Riepl <onitake at gmail.com> ---
Thanks for the patch!

A few comments on the code:

                     strcpy(szMyStuffTarget, szPersonalTarget);
                     if (_SHAppendToUnixPath(szMyStuffTarget,
MAKEINTRESOURCEW(aidsMyStuff[i])))
-                        mkdir(szMyStuffTarget, 0777);
+                        mkdir(szMyStuffTarget, 0755);

(similar lines follow)

Are you sure that you want to circumvent the umask?
In most environments, the group and owner write bits are masked out anyway, and
sometimes users might have set a less restrictive umask. This mode will prevent
that, and I don't think it is relevant to the issue anyway.

There seem to be some whitespace issues as well.

And where is _SHCreateSymbolicLinks defined?

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.