[Bug 43912] New: wine-2.0.3/programs/wineboot/wineboot.c:684]: (style) Suspicious condition
wine-bugs at winehq.org
wine-bugs at winehq.org
Sat Oct 21 02:19:40 CDT 2017
https://bugs.winehq.org/show_bug.cgi?id=43912
Bug ID: 43912
Summary: wine-2.0.3/programs/wineboot/wineboot.c:684]: (style)
Suspicious condition
Product: Wine
Version: 2.0.3
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: programs
Assignee: wine-bugs at winehq.org
Reporter: dcb314 at hotmail.com
Distribution: ---
wine-2.0.3/programs/wineboot/wineboot.c:684]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
Source code is
if ((res = RegCreateKeyExW( hkWin, szKeyName, 0, NULL, 0, bDelete ?
KEY_ALL_ACCESS : KEY_READ,
NULL, &hkRun, &dispos ) != ERROR_SUCCESS))
Maybe better code
if ((res = RegCreateKeyExW( hkWin, szKeyName, 0, NULL, 0, bDelete ?
KEY_ALL_ACCESS : KEY_READ,
NULL, &hkRun, &dispos )) != ERROR_SUCCESS)
--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.
More information about the wine-bugs
mailing list