[Bug 43912] wine-2.0.3/programs/wineboot/wineboot.c:684]: (style) Suspicious condition

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=43912

Giacomo Orlandi <gia_ at inwind.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gia_ at inwind.it

--- Comment #6 from Giacomo Orlandi <gia_ at inwind.it> ---
I think it's better to avoid an assignment inside an if condition.
You save 1 line but you lose a lot more in readability.
And we wouldn't have needed any discussion about the parentheses either...

I'm not bitching, just giving a suggestion!
And I'm not a C programmer, but I'm my opinion this suggestion applies to all
languages.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.