[Bug 32679] cmd.exe Add support for || and &&

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=32679

alexcoffin1999 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexcoffin1999 at gmail.com

--- Comment #11 from alexcoffin1999 at gmail.com ---
Created attachment 59159
  --> https://bugs.winehq.org/attachment.cgi?id=59159
A path that adds support for "||" and "&&" with errorlevel checking

Adds the support for correct error checking and should work with multiple
layers of "call"s with "&&"s and "||"s. Also I didn't fix a Windows bug I
noticed where it resets the errorlevel to "1" after a specific set of
operational conditions. Feel free to add that.

This is my first path for Wine so sorry if I make any mistakes :)
Also here is the link to the Wine TestBot job if that helps:
https://testbot.winehq.org/JobDetails.pl?Key=33077

The following is copied from the commit msg:

    Added support for "&&" and "||" condition checking

    Before "&&" and "||" were supported, but they also didn't check if past
commands had failed. This commit removes direct access to errorlevel. Now
errorlevel can only be accessed using getters and setters, but the it seemed
like the most efficient solution. Also please note I added one TODO task.
Currently this commit doesn't replicate a certain windows bug. See
test_builtins.cmd for more details.

    Also tests in test_builtins.cmd were added in order to validate these
changes.

    Finally I think I changed some random tabs to spaces in one file. Hopefully
that doesn't cause commit issues

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.