[Bug 44902] CRASH WHEN INSTALLING BAIDU WIFI HOTSPOT

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=44902

Louis Lenders <xerox.xerox2000x at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xerox.xerox2000x at gmail.com

--- Comment #1 from Louis Lenders <xerox.xerox2000x at gmail.com> ---
Created attachment 60991
  --> https://bugs.winehq.org/attachment.cgi?id=60991
debuglog

Confirming.

Seems to crash because of this:

03c:trace:shell:IShellLinkW_fnSetIconLocation (0x173680)->(path=(null) iicon=0)

Adding a check like below makes the crash dissappear, but after that a window
*I guess the main program?) comes up that is completely black. No idea why

diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c
index 6dca9ac..29e1c78 100644
--- a/dlls/shell32/shelllink.c
+++ b/dlls/shell32/shelllink.c
@@ -1930,7 +1930,7 @@ static HRESULT WINAPI
IShellLinkW_fnGetIconLocation(IShellLinkW * iface, LPWSTR
 static HRESULT WINAPI IShellLinkW_fnSetIconLocation(IShellLinkW * iface,
LPCWSTR pszIconPath,INT iIcon)
 {
     IShellLinkImpl *This = impl_from_IShellLinkW(iface);
-
+    if(!pszIconPath) return E_INVALIDARG;
     TRACE("(%p)->(path=%s iicon=%u)\n",This, debugstr_w(pszIconPath), iIcon);

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.